Extend file cloning of attachments to ABI.EncodedAttachment.#1616
Merged
Extend file cloning of attachments to ABI.EncodedAttachment.#1616
ABI.EncodedAttachment.#1616Conversation
This PR ensures that an `ABI.EncodedAttachment` instance that's wrapping an instance of `AnyAttachable` (i.e. one that has not yet been encoded to JSON) will still be able to clone its underlying file where appropriate. I haven't tried to plumb this through attachments stored solely as file paths because they've already been serialized/deserialized by that point, which implies a slow path anyway. We can revisit that in a future PR if we think it's valuable.
grynspan
added
the
tools integration
grynspan
added
performance
stmontgomery
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that an
ABI.EncodedAttachmentinstance that's wrapping an instance ofAnyAttachable(i.e. one that has not yet been encoded to JSON) will still be able to clone its underlying file where appropriate.I haven't tried to plumb this through attachments stored solely as file paths because they've already been serialized/deserialized by that point, which implies a slow path anyway. We can revisit that in a future PR if we think it's valuable.
Follow-up to #1590 and #1587.
Checklist: